Skip to content

SNOW-3309660: Fix XML tests to run in Snowfort#4200

Merged
sfc-gh-mayliu merged 4 commits intomainfrom
SNOW-3309660-fix-xml-tests-for-snowfort
Apr 30, 2026
Merged

SNOW-3309660: Fix XML tests to run in Snowfort#4200
sfc-gh-mayliu merged 4 commits intomainfrom
SNOW-3309660-fix-xml-tests-for-snowfort

Conversation

@sfc-gh-mayliu
Copy link
Copy Markdown
Collaborator

@sfc-gh-mayliu sfc-gh-mayliu commented Apr 23, 2026 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-3309660

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  • Fix StringType for Iceberg tables: Iceberg tables report a max string size of 134217728, which differs from the regular Snowflake max of 16777216. Previously, convert_sf_to_sp_type only checked against the regular max, so Iceberg string columns were returned as StringType(134217728) with _is_max_size=False, breaking equality with StringType()
  • Fix XML integration test for stored procedure environments: test_read_xml_row_tag used collect() to materialize full result sets, which fails inside stored procedures when the result is large enough to trigger paginated download URLs (unsupported by StoredProcRestfulSession). Replaced with count() + len(df.columns) to validate row/column counts without materializing the data.

@sfc-gh-mayliu sfc-gh-mayliu requested review from a team as code owners April 23, 2026 21:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-mayliu sfc-gh-mayliu force-pushed the SNOW-3309660-fix-xml-tests-for-snowfort branch from 0ba6aac to 4e0ef2f Compare April 23, 2026 22:32
@sfc-gh-mayliu
Copy link
Copy Markdown
Collaborator Author

sfc-gh-mayliu commented Apr 23, 2026

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-mayliu sfc-gh-mayliu force-pushed the SNOW-3309660-fix-xml-tests-for-snowfort branch from 4c90ae6 to 39e0823 Compare April 23, 2026 22:53
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 23, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.42%. Comparing base (c3cc950) to head (b8c5392).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4200      +/-   ##
==========================================
+ Coverage   95.10%   95.42%   +0.31%     
==========================================
  Files         171      171              
  Lines       43840    43840              
  Branches     7517     7517              
==========================================
+ Hits        41696    41833     +137     
+ Misses       1334     1226     -108     
+ Partials      810      781      -29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-mayliu sfc-gh-mayliu merged commit 75260b9 into main Apr 30, 2026
32 checks passed
@sfc-gh-mayliu sfc-gh-mayliu deleted the SNOW-3309660-fix-xml-tests-for-snowfort branch April 30, 2026 21:54
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-joshi sfc-gh-joshi sfc-gh-joshi approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-mayliu @codecov-commenter @sfc-gh-aling @sfc-gh-joshi